Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: a way to start globbing from a specific basedir #2030

Merged
merged 3 commits into from
Jul 29, 2018
Merged

Suggestion: a way to start globbing from a specific basedir #2030

merged 3 commits into from
Jul 29, 2018

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Jul 22, 2018

Description

I suggest this simple helper in Globbing that allow to start from a base directory, providing a syntax that I find clearer where the basedir is specified as the starting point :

// Before
let projects =
    !! "**/*.fsproj"
    |> GlobbingPattern.setBaseDir "src"

// After
let projects =
    GlobbingPattern.createFrom "src"
    ++ "**/*.fsproj"

TODO

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)
  • Fake 5 API guideline is honored

@matthid
Copy link
Member

matthid commented Jul 25, 2018

Should we obsolete setBaseDir eventually?

@vbfox
Copy link
Contributor Author

vbfox commented Jul 25, 2018

I personally think yes eventually as "start here & match that" is the more logical order

@matthid matthid merged commit e113e64 into fsprojects:release/next Jul 29, 2018
@matthid
Copy link
Member

matthid commented Jul 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbfox @matthid